Skip to content

couple of mini bug fixes#47

Merged
nesnes merged 2 commits into
mainfrom
cpp-bug-fix
Apr 30, 2026
Merged

couple of mini bug fixes#47
nesnes merged 2 commits into
mainfrom
cpp-bug-fix

Conversation

@trns1997
Copy link
Copy Markdown
Collaborator

  • Destroy sockfd_ on destruction
  • init sockfd_ to -1 to avoid garbage fd when TELEPLOT_DISABLE
  • set O_NONBLOCK after socket creation to avoid stalling
  • remove dead lastBufferingFlushTimestampUs_ member
  • fix typos

Comment thread clients/cpp/Teleplot.h Outdated
@trns1997 trns1997 requested a review from nesnes April 24, 2026 15:32
@trns1997
Copy link
Copy Markdown
Collaborator Author

ping @lokiledev , first stage to conan distribution

@nesnes
Copy link
Copy Markdown
Owner

nesnes commented Apr 26, 2026

I'm sir you tried Teleplot, but as you also changed some code in Telecmd, did you also tested it?

@trns1997
Copy link
Copy Markdown
Collaborator Author

I'm sir you tried Teleplot, but as you also changed some code in Telecmd, did you also tested it?

Ofcourse, I tested using the example scripts in the README. There are no regressions, everything runs as expected.

Copy link
Copy Markdown

@lokiledev lokiledev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trns1997
Copy link
Copy Markdown
Collaborator Author

ping @nesnes if things look good to you, can i merge this?

@nesnes nesnes merged commit 6519339 into main Apr 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants